Removed embedded Jackson sources. #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the embedded Jackson sources. Instead, we now rely on the jackson-core-asl.jar file (version 1.9.13) as an external dependency. Various changes were made to the ant-scripts to include the new library on the class-path. The NetBeans and IntelliJ configurations were also changed to reference the new dependency. The Jackson license file was also added.
Member
|
Apologies for not being able to contribute, but seeing this project being so lovingly crafted towards a more powerful and welcome place is very exciting! And I know of some government folks who are quite interested in the progress being made here. |
Member
Author
|
Hi @PJHogan. No problem. It is great to hear that there is some external interest. Any additional interest is always welcome as we need to get a lot more people involved here if we want this project to take off. |
emxsys
approved these changes
Apr 13, 2019
Member
emxsys
left a comment
emxsys
left a comment
There was a problem hiding this comment.
@wcmatthysen Looks good. I tested this branch with the gov.nasa.worldwindx.examples.FlatWorldEarthquakes example application which uses a USGS GeoJSON feed for input. I did not detect any problems.
Closed
emxsys
added a commit
to emxsys/WorldWindJava
that referenced
this pull request
Apr 14, 2019
- Migrated settings to IntelliJ IDEA Community Edition 2019.1 - Renamed IDE project to WorldWindJava-CE to differentiate between forks. - Added jackson.jar to dependencies (Re: PR WorldWindEarth#23) - Excluding NetBeans project folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Removed the embedded Jackson sources. Instead, an external
jackson-core-asl.jarfile was added that provides the Jackson parsing functionality.Why Should This Be In Core?
We should not embed external library sources in WorldWind. External libraries should be included as jar file dependencies. If we decide to switch over to a Maven or Gradle based way of building the project it will be easier to just include Jackson as an external dependency.
Benefits
Less pollution of the code-base with external sources. Easier migration to a newer version of Jackson in the future.
Potential Drawbacks
Users that relied on the embedded version of Jackson transitively (i.e. they received and used Jackson classes via WorldWind as a dependency) will now need to include the
jackson-core-asl.jarfile on their classpath or potentially encounter class-not-found errors.Applicable Issues
See issue: #22