Skip to content

Conversation

@wcmatthysen
Copy link
Member

Description of the Change

Removed the execute permissions from some files that do not require these permissions to be set. Execute permissions should only be set where it makes sense (such as scripts).

Why Should This Be In Core?

General cleanup of the code-base keeps it tidy.

Benefits

Less confusion as to which files can be executed (especially on Linux and MacOS).

Potential Drawbacks

None

Applicable Issues

None

Removed the execute permissions from some files that do not require
these permissions to be set. Execute permissions should only be set
where it makes sense (such as scripts).
@wcmatthysen wcmatthysen added the task Not a bug label Apr 15, 2019
@wcmatthysen wcmatthysen added this to the WWJ-CE 2.2.0 milestone Apr 15, 2019
@wcmatthysen wcmatthysen self-assigned this Apr 15, 2019
@wcmatthysen wcmatthysen requested a review from emxsys April 15, 2019 14:55
Copy link
Member

@emxsys emxsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@emxsys emxsys merged commit 648874a into WorldWindEarth:develop Apr 15, 2019
@wcmatthysen wcmatthysen deleted the fix-file-permissions branch April 15, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task Not a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants