composite: Skip copying parent pixmap contents when possible #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 12, 2025 02:47
…ely necessary" This reverts commit X11Libre@2ab2454 In the pParent->drawable.depth == pWin->drawable.depth case, pWin may already have valid contents, which need to be copied to the new pixmap.
If the parent window has a different depth (which means pWin can't have valid contents yet) and pWin has effective background other than None.
stefan11111
requested review from
a team,
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000 and
metux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the parent window has a different depth (which means pWin can't have valid contents yet) and pWin has effective background other than None.
Ported https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2092 from Xorg.
@guiodic If you still have an Xlibre machine to test, I'm guessing the lighter version of this, https://gitlab.freedesktop.org/xorg/xserver/-/commit/7e6c55cc9f5f26ef8afa74b2e86e883ce2ec1163#note_3148366 , still breaks, as described in https://gitlab.freedesktop.org/xorg/xserver/-/commit/7e6c55cc9f5f26ef8afa74b2e86e883ce2ec1163#note_3148404 ?
@metux I wonder what exact circumstances are occurring here, such that not populating a pixmap with effective background not None leads to breakages? Do you have an idea what cases other than effective background None might need these copies?