Skip to content

Conversation

@pratikmankawde
Copy link
Collaborator

High Level Overview of Change

This change retires the fix1781 amendment.

Context of Change

Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fix1781

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde pratikmankawde requested a review from a team as a code owner October 23, 2025 15:58
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.3%. Comparing base (1dd6024) to head (e35d865).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/paths/detail/XRPEndpointStep.cpp 40.0% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5931     +/-   ##
=========================================
- Coverage     78.3%   78.3%   -0.0%     
=========================================
  Files          817     817             
  Lines        68980   68978      -2     
  Branches      8329    8324      -5     
=========================================
- Hits         54021   54017      -4     
- Misses       14959   14961      +2     
Files with missing lines Coverage Δ
src/xrpld/app/paths/detail/XRPEndpointStep.cpp 83.3% <40.0%> (+0.5%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Amendments activated for more than 2 years can be retired. This change retires the fix1781 amendment.
@bthomee bthomee force-pushed the pratik/retire_fix1781_amendment branch from 44f28c2 to cac5fcc Compare October 28, 2025 15:18
@bthomee bthomee enabled auto-merge October 28, 2025 15:18
@pratikmankawde pratikmankawde added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Oct 28, 2025
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
…ppled into pratik/retire_fix1781_amendment

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@bthomee bthomee added this pull request to the merge queue Oct 29, 2025
Merged via the queue into develop with commit a8e4da0 Oct 29, 2025
37 of 38 checks passed
@bthomee bthomee deleted the pratik/retire_fix1781_amendment branch October 29, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants