consensus: verify with masternodes list instead of candidates, close XFN-62 #1724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzliudan
changed the title
| } | ||
|
|
||
| snapshot, err := x.getSnapshot(chain, vote.GapNumber, true) | ||
| masternodes, err:= x.GetMasternodesFromGapNumber(chain, vote.GapNumber) |
Collaborator
There was a problem hiding this comment.
There is vote proposedBlockInfo with block number, use that number to get header is faster
Collaborator
|
please change merge target branch to |
| } | ||
|
|
||
| snapshot, err := x.getSnapshot(chain, vote.GapNumber, true) | ||
| prevBlockHeader := chain.GetHeaderByNumber(vote.ProposedBlockInfo.Number.Uint64()-1) |
Collaborator
There was a problem hiding this comment.
check how vote.gap number get calculated and use the same method for calculated getEpochSwitchInfo
| verified, err := engineV2.VerifyVoteMessage(blockchain, voteMsg) | ||
| assert.False(t, verified) | ||
| assert.NotNil(t, err) | ||
| assert.Nil(t, err) |
Collaborator
There was a problem hiding this comment.
then you can delete this test
Collaborator
There was a problem hiding this comment.
change this task when epochswitchinfo is not found
Collaborator
Author
|
won't merge in this mainnet release due to change risk |
Merged
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
verify from masternodes instead of snap.NextEpochCandidates (masternodes = candidates - standbys - penalties)
ref audit ticket: XFN-62
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that