Merged
Conversation
|
@mretegan thanks for your work on this. For the edges, I think we should allow only the IUPAC notation. Contrary to the emission lines, it is rather simple to identify the edge in IUPAC notation. The ASCII notation is misleading because it can be either written in LaTeX or another way. I would keep the ASCII notation in the documentation, but the enumeration should keep only IUPAC. Again, I find clear how is stated in the XrayDB documentation: https://xraypy.github.io/XrayDB/overview.html#x-ray-edges |
Author
|
@maurov Okay, I updated the definition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few missing ones and a short definition.