Merged
Conversation
woutdenolf
force-pushed
the
add_esrf_bm16_data
branch
2 times, most recently
from
52eb38b to
a30a1e4
Compare
woutdenolf
force-pushed
the
add_esrf_bm16_data
branch
from
a30a1e4 to
89c966c
Compare
woutdenolf
force-pushed
the
add_esrf_bm16_data
branch
from
3779d12 to
351b48c
Compare
mretegan
approved these changes
Jan 22, 2025
| from pathlib import Path | ||
|
|
||
| import h5py | ||
| import numpy |
Contributor
There was a problem hiding this comment.
They recommend to import as import numpy as np. Not critical, though.
Member
Author
There was a problem hiding this comment.
import numpy as np
import pandas as pd
...I'm not a favor for the same reason I'm not in favor of single letter variable names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nexusformat)Rendered docs with HDF5 links: https://pynxxas.readthedocs.io/en/add_esrf_bm16_data/