This repository was archived by the owner on Jul 12, 2020. It is now read-only.
Open
Conversation
Kfeavel
reviewed
Oct 4, 2019
Kfeavel
reviewed
Oct 4, 2019
Kfeavel
reviewed
Oct 4, 2019
Kfeavel
reviewed
Oct 4, 2019
Member
Kfeavel
left a comment
Kfeavel
left a comment
There was a problem hiding this comment.
Mostly style guide issues here. Seems fine otherwise except for the port still being in the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This driver is a work in progress. This is just a place to have an open discussion about how the driver should be implemented.
TODO: