Skip to content
This repository was archived by the owner on Jul 12, 2020. It is now read-only.

WIP: Adds Static Pointers to Active Managers Accessible Everywhere#79

Open
Kfeavel wants to merge 17 commits intodevfrom
active-managers-fix
Open

WIP: Adds Static Pointers to Active Managers Accessible Everywhere#79
Kfeavel wants to merge 17 commits intodevfrom
active-managers-fix

Conversation

@Kfeavel
Copy link
Member

@Kfeavel Kfeavel commented Oct 4, 2019

This fixes the issue of not having access to any of the managers where they are needed. Now each class has a static pointer to the active manager that can be accessed via the ClassName::activeManager syntax

@Kfeavel Kfeavel self-assigned this Oct 4, 2019
@Kfeavel Kfeavel changed the title Adds Static Pointers to Active Managers Accessible Everywhere WIP: Adds Static Pointers to Active Managers Accessible Everywhere Oct 4, 2019
@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2019

This pull request introduces 3 alerts when merging 1a1d1bc into de0eef7 - view on LGTM.com

new alerts:

  • 2 for FIXME comment
  • 1 for Returning stack-allocated memory

@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2019

This pull request introduces 4 alerts when merging 053b34d into de0eef7 - view on LGTM.com

new alerts:

  • 3 for FIXME comment
  • 1 for Returning stack-allocated memory

@lgtm-com
Copy link

lgtm-com bot commented Oct 7, 2019

This pull request introduces 4 alerts when merging bde22c8 into cf84489 - view on LGTM.com

new alerts:

  • 3 for FIXME comment
  • 1 for Returning stack-allocated memory

@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2019

This pull request introduces 4 alerts when merging a6ed755 into cf84489 - view on LGTM.com

new alerts:

  • 3 for FIXME comment
  • 1 for Returning stack-allocated memory

@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2019

This pull request introduces 5 alerts when merging e6a4903 into cf84489 - view on LGTM.com

new alerts:

  • 4 for FIXME comment
  • 1 for Returning stack-allocated memory

@todo
Copy link

todo bot commented Oct 16, 2019

Add getHandler() function to return the handler so we can cast it in the getDriverByTag

https://github.com/panix-os-dev-team/Panix/blob/788e1467554190adad33ebef5764a45c4d8ec55a/include/drivers/Driver.hpp#L45-L48


This comment was generated by todo based on a TODO: comment in 788e146 in #79. cc @panix-os-dev-team.

@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2019

This pull request introduces 5 alerts when merging 788e146 into cf84489 - view on LGTM.com

new alerts:

  • 4 for FIXME comment
  • 1 for Returning stack-allocated memory

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant