[TNT-28] feat: Authentication Filter 구현 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymkim97
reviewed
Jan 7, 2025
ymkim97
reviewed
Jan 7, 2025
|
|
||
| public String authenticate(HttpServletRequest request) { | ||
| String authHeader = request.getHeader(AUTHORIZATION_HEADER); | ||
| String sessionId; |
Member
There was a problem hiding this comment.
아까 초기화가 안되는 것들은 위에 두자고 했지만 그거는 로직상 어쩔 수 없을때만 하고 웬만해서는 중간에 String sessionId = authHeader.substring(SESSION_ID_PREFIX.length());가 더 좋을 것 같긴 합니다 ㅎㅎ
Contributor
Author
There was a problem hiding this comment.
아하 중간에 다시 수정해서 푸쉬할게요 !!
ymkim97
reviewed
Jan 7, 2025
| String queryString = request.getQueryString(); | ||
|
|
||
| log.info("들어온 요청 - URI: {}, Query: {}, Method: {}", requestUri, queryString != null ? queryString : "쿼리 스트링 없음", | ||
| request.getMethod()); |
Member
There was a problem hiding this comment.
log들은 로직에 섞여 보이지 않게 개행 처리로 구분해주는건 어떨까요!? 다른쪽들도 다 마찬가지 입니다!
Contributor
Author
There was a problem hiding this comment.
아하 좋습니다 바로 수정 들어가겠습니다 !!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Checklist
[APP2-77] feat: 회원 인증 Filter 구현)🎟️ Issue
✅ Tasks
※ 원기옥 죄송합니다 다음엔 분량 적게 PR 하도록 할게여
세션 인증 필터 구현, 회원 엔티티 구현
회원 엔티티
세션 구조
세션 스토리지
세션 인증 필터 동작 순서
1-1. 허용 URI는 검증 과정 없이 바로 다음 필터로 진행
2-1. 세션이 없으면 예외 발생
3-1. Redis에 없으면 예외 발생
4-1. 유효 기간 만료된 세션은 Redis에서 삭제하고 예외 발생
클라이언트에서 회원 이상 권한 API 요청 시
추가 작업
🙋🏻 More
Session Authentication Filter Test
Session Service Test
Member Test
