feat(tl): add sum method to ancestral_states#54
Merged
Conversation
… traversal Uses reversed topological sort for efficient O(n) aggregation without recursion or intermediate list storage. Respects fixed_nodes and array keys. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 93.92% 93.95% +0.02%
==========================================
Files 35 35
Lines 2932 2943 +11
==========================================
+ Hits 2754 2765 +11
Misses 178 178
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summethod toancestral_statesthat computes the sum of leaf values in each node's subtree.reversed(nx.topological_sort(...))— O(n), no recursion, no intermediate list storage.fixed_nodes(fixed internal nodes are treated as leaves).mean).Test plan
test_ancestral_states_sum— scalar values summed correctly up tree1 and tree2test_ancestral_states_sum_array— array (spatial) values summed element-wisetest_ancestral_states_sum_fixed_nodes— fixed internal nodes are not overwritten🤖 Generated with Claude Code