Open
Conversation
Yuto729
changed the title
nodchip
reviewed
Dec 23, 2025
| if len(index_list) > 1: | ||
| continue | ||
|
|
||
| if len(index_list) == 0: |
There was a problem hiding this comment.
こちらのコメントをご参照ください。
mamo3gr/arai60#6 (comment)
| if len(index_list) == 0: | ||
| continue | ||
|
|
||
| if first_index == -1: |
There was a problem hiding this comment.
first_index を大きな数で初期化すると、この if 文が不要になり、シンプルになると思います。
5ky7
reviewed
Dec 24, 2025
| if len(index_list) > 1: | ||
| continue | ||
|
|
||
| if len(index_list) == 0: |
There was a problem hiding this comment.
defaultdictではアクセスされていないkeyがfor文で取り出されることはないので，このif文は常にfalseですね．
| first_index = index_list[0] | ||
| continue | ||
|
|
||
| first_index = min(first_index, index_list[0]) |
There was a problem hiding this comment.
python3.7以降ではdefaultdictのfor文による取り出しは要素を追加した順番でとり出されるので，初めてlen(index_list) == 1となる要素が来た時点でearly returnできます．
互換性を考えるとこのままでも良いかもしれません．
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解く問題
First Unique Character In A String
次に解く問題
Subarray Sum Equals K