Conversation
tom4649
reviewed
Mar 17, 2026
| result = [] | ||
| path = [] | ||
|
|
||
| def dfs(node, remaining): |
There was a problem hiding this comment.
自分が指摘されたミスですが、dfsの関数名だと何も表現できていないので、traverseのような動作を表す関数名が望ましいと思います。
nodchip
reviewed
Mar 18, 2026
| ```py | ||
| class Solution: | ||
| def hasPathSum(self, root: Optional[TreeNode], targetSum: int) -> bool: | ||
| if not root: |
There was a problem hiding this comment.
not root と node is None が混在しているのが気になりました。 is None に統一することをお勧めいたします。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解く問題
Path Sum
次に解く問題
Binary Tree Level Order Traversal