Skip to content

added product LMO#97

Merged
matbesancon merged 3 commits intomasterfrom
lmo-product
Mar 1, 2021
Merged

added product LMO#97
matbesancon merged 3 commits intomasterfrom
lmo-product

Conversation

@matbesancon
Copy link
Copy Markdown
Member

This introduces a LMO representing the cartesian product of N sets, with their corresponding LMOs

@pokutta
Copy link
Copy Markdown
Member

pokutta commented Feb 22, 2021

(super useful!!)

@matbesancon
Copy link
Copy Markdown
Member Author

@pokutta another interesting change on this PR:
all LMOs now accept all keyword arguments, and just pick the ones they use. This could be useful for #86, all LMOs could accept an argument nearest=true but just ignore it if it is not relevant for a given LMO

@pokutta
Copy link
Copy Markdown
Member

pokutta commented Feb 24, 2021

that's a very good idea!

@pokutta
Copy link
Copy Markdown
Member

pokutta commented Mar 1, 2021

this is conflicting now with the lp_norm code -> also if this is fine we should merge this

@matbesancon
Copy link
Copy Markdown
Member Author

I'll update the branch to merge it

@matbesancon matbesancon merged commit dd8e1d0 into master Mar 1, 2021
@matbesancon matbesancon deleted the lmo-product branch March 1, 2021 11:18
dhendryc pushed a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants