Skip to content

Conversation

@pbricout
Copy link
Contributor

@pbricout pbricout commented Dec 9, 2022

Can be reviewed commit by commit, each commit contains a message with details.

Unfortunately, it seems the API-extractor/API-documenter, does not deal well with callable interfaces and types and especially the ones with overloads. I could find an easy to document the overloads. Currently the documentation for each overload of the ReadCallback is ignored.

Summary of the commit messages:

Simplify index exports
Anything in these files should be exported, let's simplify.
API Extractor examples look like this.

Reformat tsconfig.json
Change the identation to 4.
Reformat using reformat in VSCode.
This will make review easier.

Setup API Extractor and API Documenter
Initialisation steps:

  • npx api-extractor init to generate the initial configuration
  • mkdir config (following recommended practices)
  • mv api-extractor.json config/api-extractor.jsonc

Output folder etc will produce the report it is recommended
to keep this report to track and review API differences.
Output folder doc will contain the API documentation in
markdown format.

Change build folder from dist to lib which is the api-extractor
default (so following api-extractor recommended).

See:
https://api-extractor.com/
https://api-extractor.com/pages/setup/generating_docs/

Configure API extractor

Add TSDoc public tags

Update package.json

Add more API documentation

@pbricout pbricout force-pushed the setup-api-extractor branch 4 times, most recently from 622bc6f to 49c1ab0 Compare December 10, 2022 17:45
@pbricout pbricout force-pushed the setup-api-extractor branch from 49c1ab0 to 359c3e0 Compare March 14, 2023 00:31
pbricout added 10 commits March 15, 2023 00:56
Anything in these files should be exported, let's simplify.
API Extractor examples look like this.
Change the identation to 4.
Reformat using `reformat` in VSCode.
This will make review easier.
Initialisation steps:
- `npx api-extractor init` to generate the initial configuration
- `mkdir config` (following recommended practices)
- `mv api-extractor.json config/api-extractor.jsonc`

Output folder `etc` will produce the report it is recommended
to keep this report to track and review API differences.
Output folder `doc` will contain the API documentation in
markdown format.

Change build folder from `dist` to `lib` which is the api-extractor
default (so following api-extractor recommended).

See:
https://api-extractor.com/
https://api-extractor.com/pages/setup/generating_docs/
- add some TSDoc public tags
This will allow to better re-use the types.
- use `npm run build-all`
@pbricout pbricout force-pushed the setup-api-extractor branch from 359c3e0 to d420664 Compare March 14, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant