Fix build for GCC 15 and add Arch Linux support#107
Open
RhettCreighton wants to merge 1 commit intomasterfrom
Open
Fix build for GCC 15 and add Arch Linux support#107RhettCreighton wants to merge 1 commit intomasterfrom
RhettCreighton wants to merge 1 commit intomasterfrom
Conversation
GCC 15 defaults to C23 semantics where void f() means no parameters, breaking GMP 6.3.0 configure tests. Add -std=gnu17/-std=gnu++17 to depends CFLAGS/CXXFLAGS to restore compatibility. Fix FakeCoinsViewDB::DB_COINS ODR violation that causes link failure with GCC 15 by copying the static member to a local variable before passing to std::make_pair. Pass explicit --with-boost, CPPFLAGS, and LDFLAGS in build.sh to fix unreliable depends_prefix resolution in config.site with newer autoconf. Add Arch/Manjaro/EndeavourOS/Garuda support to install-deps.sh. Update BUILD.md with Arch Linux instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-std=gnu17/-std=gnu++17CFLAGSFakeCoinsViewDB::DB_COINSODR-use link failure with GCC 15build.shto pass explicit--with-boost,CPPFLAGS, andLDFLAGSto configure, resolving unreliabledepends_prefixresolution in config.site with newer autoconfinstall-deps.shBUILD.mdwith Arch Linux build instructionsDetails
GCC 15 + GMP 6.3.0: GCC 15 defaults to C23 where
void g(){}means "no parameters". GMP's configure test calls such a function with arguments, causing the compiler reliability test to fail. Setting-std=gnu17restores the old behavior.ODR violation:
static const char DB_COINS = 'c'inFakeCoinsViewDBis ODR-used bystd::make_pair(taken by const reference). GCC 15 enforces this strictly. Fixed by copying to a local variable.config.site boost detection: The
depends_prefixbacktick expansion in config.site can fail with newer autoconf versions, causing--with-boostto resolve to an empty path. Passing explicit paths on the configure command line is more reliable.Test plan
zclassicd,zclassic-cli,zclassic-tx