Conversation
Erikvv
force-pushed
the
card-block-flexible-height
branch
2 times, most recently
from
725f7f4 to
44b9df4
Compare
In the Binnenhaven case I noticed that the text doesn't fit on the card by 1-2 words depending on screen size. I've removed the fixed height from the card and done some refactoring to simplify the code.
Erikvv
force-pushed
the
card-block-flexible-height
branch
from
44b9df4 to
fe3e037
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Binnenhaven case (#1021) I noticed that the text doesn't fit on the card by 1-2 words depending on screen size.
I've removed the fixed height from the card and done some refactoring to simplify the code.