Conversation
Erikvv
reviewed
Feb 24, 2026
| modelId = Uuid.parse("3801076e-44db-4b42-a27f-5be2b6c82a5c"), | ||
| applicationArea = LuxApplicationArea.LUX_REGION | ||
| applicationArea = LuxApplicationArea.LUX_REGION, | ||
| isFeatured = true |
Member
There was a problem hiding this comment.
I prefer to end the last line with a comma too. When you add another property in the future the diff will be 1 line instead of 2.
Erikvv
approved these changes
Feb 24, 2026
| @Composable | ||
| fun FieldModels( | ||
| applicationArea: ApplicationArea | ||
| applicationArea: LuxApplicationArea |
Member
There was a problem hiding this comment.
Personally instead of isFeatured I would have added arguments to this component.
fun FieldModels(
applicationArea: LuxApplicationArea,
featuredModels: <TwinModelCardItem>,
showMoreModelsLink: Boolean,
)And then call it with the featured models on every page
// on LUX Business page
FieldModels(
applicationArea = LuxApplicationArea.LUX_BUSINESS,
featuredModels = listOf(cognizant, preZero),
showMoreModelsLink = false,
)
Member
There was a problem hiding this comment.
But the current approach works too, doesn't need to change.
Collaborator
Author
There was a problem hiding this comment.
I like this idea, when i started this, i was avoiding having to call FeildModels on every application area page but seems more of a simple design. I will make the change
Collaborator
Author
There was a problem hiding this comment.
Made this change, finishing this issue
kofi-k
force-pushed
the
isFeatured-models-flag
branch
from
4a5d7ec to
9f82dad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #445
The models page needs a filter by application area, then jump to models page with filter enabled feels more complete.
This will be done in a different PR.