Closed
Conversation
Split collection ordered PV Systems into two, one for houses and one for companies. Started working on list of GCs as argument to the slider functions. Added the function that calculates the percentage
Still a seperate function for houses and companies, but they use the same helper function to add or remove the assets
For companies the PV Slider scales with the total potential (based on roof surface area). For houses the slider is still just a percentage of households that have PV on their roof. If they do the amount is still randomised, which means this slider is still inconsistent, but for a large amount of houses this will average out. It is not a reasonable to assume that the amount of PV for households scales linearly with roof surface area, most houses determine their amount of PV based on the expected self consumption, which is usually the restricting factor
Contributor
|
no longer needed is now part of the woonwijk port merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires engine changes in PR: Zenmo/zero_engine#159