Major update: Heating slider updates + Company UI refactor + scenario radiobutton refactor#184
Merged
Major update: Heating slider updates + Company UI refactor + scenario radiobutton refactor#184
Conversation
mobility tab needs a lot of work as well, if that is finished, its almost done.
- Bugfix: function that updates transport saving slider on main interface was wrong. - Bugfix: function that creates batteries in companyUI now removes the battery when slider is set to 0 and correctly sets the c_rate. - Bugfix: heatingRB was not disabled for CUSTOM heating strategies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heating slider updates (meer dan 2 heating type sliders nu) (ook hybride warmtepomp voor residential , en hybride warmtepomp en districtheating en custom voor bedrijven modellen). Dit vergde een aanpassing aan de companyUI voor een werkend model.
Daarvoor moest de companyUI gerefactored worden.
-> Er wordt nu maar 1 companyUI gemaakt, die gevuld wordt met de geselecteerde GC (na het klikken op de knop : ga naar CompanyUI).
-> Om de companyUI refactor te kunnen doen moest de scenario button opzet gerefactored worden: Is nu gestandardiseerd, waardoor je custom knoppen/functies aan de radiobutton kunt toevoegen door bepaalde functies te overriden.
-> Woonwijk modellen kunnen nu ook resetten naar de huidige situatie.
Samen mergen met engine pull: Zenmo/zero_engine#211