Skip to content

Add diesel tractor#102

Merged
GillisHommen merged 2 commits intomainfrom
tractor-refactor
Feb 4, 2025
Merged

Add diesel tractor#102
GillisHommen merged 2 commits intomainfrom
tractor-refactor

Conversation

@Erikvv
Copy link
Member

@Erikvv Erikvv commented Jan 30, 2025

No description provided.

also added a collection to the GC canvas for these assets and updateAllFlows at operateFixedAssets
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

@Erikvv Erikvv requested a review from Luc-Sol January 30, 2025 13:23
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

@Erikvv
Copy link
Member Author

Erikvv commented Jan 30, 2025

  • Fix: putting kW in flows map instead of kWh
  • Did the conversion from L to kWh earlier (i guess it can be done even earlier in the constructor)

@GillisHommen
Copy link
Contributor

Is a separate collection on the GC-canvas needed? What makes this asset different from a 'consumptionAsset', from the GCs frame of reference?

@Erikvv
Copy link
Member Author

Erikvv commented Feb 3, 2025

Is a separate collection on the GC-canvas needed? What makes this asset different from a 'consumptionAsset', from the GCs frame of reference?

After consulting @Luc-Sol, changed it to add the tractor to profileAsset collection instead.

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

I am aware that this is nitpicking and doesn't solve any fundamental
issue.
@github-actions
Copy link

github-actions bot commented Feb 3, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

@GillisHommen
Copy link
Contributor

I still get confused by the force-pushes/amend commit WOW. None of us use this method, and it makes it harder for me to understand what changes have been made in this pull request. Can you try to explain it again to me, or otherwise use the 'conventional' way where you just use more commits instead of changing/replacing existing ones?

@GillisHommen GillisHommen merged commit 7267065 into main Feb 4, 2025
2 checks passed
@GillisHommen GillisHommen deleted the tractor-refactor branch February 18, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants