Conversation
… there are 100% EVs and a rapidrun is started (Vermeerkwartier)
…meVariables from rapidRun, instead of 'old' from liveSim. Changed order of f_rapidRunSimulation; timeVariables object is now updated to rapidRun-state before calling all reset functions. Test if this has any other effects before merging into main!
Contributor
Author
|
Tested Genius model to check if simulation results are unaffected: Pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must test effect of changed order in f_rapidRunSimulation! timeVariables is now updated before calling all reset functions.
Holon-EV charging algorithm works, can still give warnings when moving EV-sliders during live-sim, but this is inconsequential for the actual results.