AES key length is not equal to AES block size#47
Open
DibranMulder wants to merge 2 commits intoZeroPass:masterfrom
Open
AES key length is not equal to AES block size#47DibranMulder wants to merge 2 commits intoZeroPass:masterfrom
DibranMulder wants to merge 2 commits intoZeroPass:masterfrom
Conversation
Member
|
Thank you for providing this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dutch Passports have a AES256 bit key length. The assumption that the block size which is always 16 bytes (128 bits) with AES is also the key length is simply incorrect. This PR fixes #31 on your side but sadly the same issue is made in Pointy Castle.
These are the errors people often encounter.