Add dg2, dg7 and dg11 by arosasg · Pull Request #3 · ZeroPass/pymrtd

arosasg · 2024-05-18T07:57:09Z

Added dg2
Added dg7
Added dg11
Restructure ef code

smlu · 2024-05-19T19:26:37Z

Thank you for this PR! I'll be reviewing it shortly.

nejc-skerjanc · 2024-05-20T07:48:13Z

Check this commit:
8023116

Do the same on your branch. Library has been changed and therefore it throws few errors.

arosasg · 2024-05-21T15:17:56Z

Check this commit: 8023116

Do the same on your branch. Library has been changed and therefore it throws few errors.

Done

smlu · 2024-05-22T09:39:34Z

src/pymrtd/ef/__init__.py

+from .dg2 import DataGroup2
+
+from .sod import SOD, SODError
+


Could you revert include style back to original.

smlu · 2024-05-22T09:41:10Z

src/pymrtd/ef/dg.py

+        ("aa_info", ActiveAuthenticationInfo),
+        ("chip_auth_info", ChipAuthenticationInfo),
+        ("chip_auth_pub_key_info", ChipAuthenticationPublicKeyInfo),
+        # Note: Missing PACEDomainParameterInfo and PACEInfo


Use single quote mark.

smlu · 2024-05-22T09:41:42Z

src/pymrtd/ef/dg.py

+        13: "EF.DG13",
+        14: "EF.DG14",
+        15: "EF.DG15",
+        16: "EF.DG16",


Use single quote mark.

smlu · 2024-05-22T09:41:51Z

src/pymrtd/ef/dg.py

                value = 4
            elif value not in DataGroupNumber._map:
-                raise ValueError('Invalid data group number')
+                raise ValueError("Invalid data group number")


Use single quote mark.

smlu · 2024-05-22T09:42:07Z

src/pymrtd/ef/dg.py

    @property
    def native(self):
-        return { 'mrz': self.mrz.native }
+        return {"mrz": self.mrz.native}


Use single quote mark.

smlu · 2024-05-30T08:32:25Z

tests/ef/mrz_test.py

+    assert mrz.dump() == tv
+    assert mrz.type == "td3"
+    assert mrz.documentCode == "P"
+    assert mrz.country == "D"
+    assert mrz.documentNumber == "C11T002JM"
+    assert mrz["document_number_cd"] == 4
+    assert mrz["optional_data"] == ""
+    assert mrz.additionalData == ""
+    assert mrz["optional_data_cd"] == 0
+    assert mrz.dateOfBirth == date(1996, 8, 12)
+    assert mrz["date_of_birth_cd"] == 2
+    assert mrz.gender == "F"
+    assert mrz.dateOfExpiry == date(2023, 10, 31)
+    assert mrz["date_of_expiry_cd"] == 4
+    assert mrz.nationality == "D"
+    assert mrz["composite_cd"] == 4
+    assert mrz["name_identifiers"] == ("MUSTERMANN", "ERIKA")
+    assert mrz.name == "ERIKA"
+    assert mrz.surname == "MUSTERMANN"
