fix: single layer ng annotation in collection results in 0 z-size bbox#1203
Merged
fix: single layer ng annotation in collection results in 0 z-size bbox#1203
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 192 192
Lines 10203 10206 +3
=======================================
+ Hits 10201 10204 +3
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
supersergiy
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
shrinkmode fromsnapped()function reduces bbox z-size to 0. The proper way is to floor the coordinates instead and matches the way neuroglancer handles coordinates.Background:
Coordinates are stored in units of 1nm.
snapped()is normally used to align bboxes to chunks, this was repurposed to align to resolution coordinates. Usingshrinkwould always add 1 to each coordinate when the correct behavior should be just flooring. Thus a newfloormode is added tosnapped()andbuild_collection_dataset()is changed to use the newfloormode.