Skip to content

Fix public devnet config and add additional interop case#3548

Merged
bzawisto merged 4 commits intomainfrom
users/lukasz/confirming_string_interop
Mar 26, 2026
Merged

Fix public devnet config and add additional interop case#3548
bzawisto merged 4 commits intomainfrom
users/lukasz/confirming_string_interop

Conversation

@lukozill
Copy link
Copy Markdown
Contributor

Description

Additional test case mimics exactly the ERC721 Mint method case.

Testig

Tested with MOCHA_TIMEOUT=2000000 npx hardhat test --grep "BasicInterop" --network public_devnet

⚠️  Your Eth/Zil accounts supposed to have funds to run tests successfully.
Scilla Contracts: 
Nothing changed since last compile.


  BasicInterop
    ✔ Should be deployed successfully
    ✔ It should return revert while reading non-existing  field
    ✔ It should return 0 while reading non-existing key in simpleMap (669ms)
    ✔ It should return 0 while reading non-existing key in nestedMap (811ms)
    When call is performed from solidity to scilla contract
      ✔ It should return proper string after invoking set method with string arg (4639ms)
      ✔ It should return proper address and string after invoking set method with address and string args (4781ms)
      ✔ It should return proper integer after invoking set method for simpleMap (5769ms)
      ✔ It should return proper integer after invoking set method for nestedMap (4935ms)
      ✔ It should return proper unsigned integer after invoking set method with integer arg (4806ms)
      ✔ It should return proper integer after invoking set method with integer arg (4755ms)
      ✔ It should return proper address after invoking set method with address arg (4920ms)
      ✔ It should return proper unsigned integer value for an immutable field (659ms)
      ✔ It should return proper integer value for an immutable field (694ms)
      ✔ It should return proper string value for an immutable field (797ms)
      ✔ It should return proper address value for an immutable field (660ms)
      ✔ Should fail to read uint if field name is not available (689ms)
      ✔ Should fail to read uint if contract address is not valid


  17 passing (51s)

💰 ~17.331585 ZILs used
[ BigNumber { value: "177540790000000000000" } ]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

🐰 Bencher Report

Branchusers/lukasz/confirming_string_interop
Testbedself-hosted
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
full-blocks-erc20-transfers/full-blocks-erc20-transfers📈 view plot
🚷 view threshold
600.72 ms
(-4.05%)Baseline: 626.07 ms
719.72 ms
(83.47%)
full-blocks-evm-transfers/full-blocks-evm-transfers📈 view plot
🚷 view threshold
873.38 ms
(-0.38%)Baseline: 876.72 ms
1,022.29 ms
(85.43%)
full-blocks-giant-deploy/full-blocks-giant-deploy📈 view plot
🚷 view threshold
5,182.70 ms
(+1.44%)Baseline: 5,108.98 ms
5,535.24 ms
(93.63%)
full-blocks-scilla-add/full-blocks-scilla-add📈 view plot
🚷 view threshold
1,013.30 ms
(+0.15%)Baseline: 1,011.80 ms
1,057.24 ms
(95.84%)
full-blocks-scilla-load/full-blocks-scilla-load📈 view plot
🚷 view threshold
5,310.90 ms
(-1.91%)Baseline: 5,414.35 ms
6,085.18 ms
(87.28%)
full-blocks-scilla-store/full-blocks-scilla-store📈 view plot
🚷 view threshold
4,290.90 ms
(-0.73%)Baseline: 4,322.55 ms
4,886.79 ms
(87.81%)
full-blocks-zil-transfers/full-blocks-zil-transfers📈 view plot
🚷 view threshold
1,179.90 ms
(+18.27%)Baseline: 997.67 ms
1,351.82 ms
(87.28%)
process-empty/process-empty📈 view plot
🚷 view threshold
13.51 ms
(+20.45%)Baseline: 11.22 ms
15.57 ms
(86.80%)
🐰 View full continuous benchmarking report in Bencher

@bzawisto bzawisto enabled auto-merge March 26, 2026 20:39
@bzawisto bzawisto added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit 40858ad Mar 26, 2026
6 checks passed
@bzawisto bzawisto deleted the users/lukasz/confirming_string_interop branch March 26, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants