Venya/fix-invoke-by-reminder-but-no-state#97
Merged
VenyaBrodetskiy merged 2 commits intomasterfrom Jan 8, 2025
Merged
Conversation
…reminder, but State was deleted (by ttl or other reason)
alonf
reviewed
Jan 8, 2025
| @@ -115,7 +115,8 @@ protected override async Task OnPreActorMethodAsync(ActorMethodContext actorMeth | |||
| { | |||
| Saga = null; //just in case | |||
| Saga = ReBuildSaga(); | |||
Collaborator
There was a problem hiding this comment.
We do not need to rebuild the saga in a case of no state; the question is if it is worth the complexity of having a dedicated check. We could create a method to check the state's existence, call it as the first method in the function, and rebuild the saga if it is really needed.
Collaborator
Author
There was a problem hiding this comment.
nice idea
@SubZeroX9 wanna help with it please? 🙏
alonf
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed edge case when Saga couldn't recover in case it was invoked by reminder, but State was deleted (by ttl or other reason)