New overload for sub-saga invocation#99
Merged
VenyaBrodetskiy merged 2 commits intomasterfrom Jan 15, 2025
Merged
Conversation
Added a new CallSubSagaOptions record to encapsulate sub-saga invocation options. Updated DaprActorHost.cs with a new CallSubSagaAsync method and refactored the existing method to use CallSubSagaOptions. Modified MainSagaActor.cs to utilize the new CallSubSagaOptions record in sub-saga calls.
SubZeroX9
requested changes
Jan 15, 2025
- Change `CallbackMethodName` in `CallSubSagaOptions` to required - Initialize `CustomBindingMetadata` with an empty dictionary - Mark `CallSubSagaAsync` overload as obsolete, recommend new overload
VenyaBrodetskiy
had a problem deploying
to
test
GitHub Actions
Failure
SubZeroX9
approved these changes
Jan 15, 2025
Dimland
reviewed
Jan 15, 2025
| : options.UseBindingName; | ||
|
|
||
| // Dispatch the sub-saga invocation with a single parameter (invocationContext) | ||
| await subSagaDaprClient.InvokeBindingAsync( |
There was a problem hiding this comment.
maybe add try-catch and log for error or throw?
| var callbackContext = CaptureCallbackContext(options.CallbackMethodName); | ||
|
|
||
| // Extract method name and parameters from the expression | ||
| var methodCall = (MethodCallExpression)methodExpression.Body; |
There was a problem hiding this comment.
methodExpression.Body always have type MethodCallExpression?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new CallSubSagaOptions record to encapsulate sub-saga invocation options. Updated DaprActorHost.cs with a new CallSubSagaAsync method and refactored the existing method to use CallSubSagaOptions. Modified MainSagaActor.cs to utilize the new CallSubSagaOptions record in sub-saga calls.