Skip to content

Adding and loading options from config#427

Open
wesleymilan wants to merge 6 commits intoZizaco:masterfrom
wesleymilan:master
Open

Adding and loading options from config#427
wesleymilan wants to merge 6 commits intoZizaco:masterfrom
wesleymilan:master

Conversation

@wesleymilan
Copy link

I'd just added the username_type and validation rules into config file to avoid the needs of extend or overwrite the Zizaco classes. This can turn easier to setup and modify rules while using confide.

Thanks for do it, Confide is a great package.

Regards

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.86%) when pulling 8b19f79 on wesleymilan:master into c1280c4 on Zizaco:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.66%) when pulling 0b1a8bd on wesleymilan:master into c1280c4 on Zizaco:master.

@Zizaco
Copy link
Owner

Zizaco commented Oct 25, 2014

I'm not exactly sure if it's better to have the validation rules as configs. If an application have different business rules of how a valid user should look a like, then it's a better idea to have a class to do it.

Using the config files to do this seems like a bad idea to me :(

@Zizaco
Copy link
Owner

Zizaco commented Oct 25, 2014

Although the validation in config, to save the confirmation DateTime seems a pretty good idea. I liked it.

But I didn't get why the setTimezone is necessary. Can you explain to me?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be included. It should be part of your global system ignore file, not a project ignore file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants