Open
Conversation
|
@gabrielalmeida thanks for your support, and sorry about the delay .... please let me know if you need me to share some files, codes ? thanks again, appreciate it. |
Contributor
Author
|
Hi @megadola, apologize for the long delay. I couldn't reproduce your error message but the PR was broken and I've just updated it. If you still need to get it working, take a look now. |
One cannot set new password because Confide expects all mandatory form fields from an update to be sent, as a password change this only sends password and password_confirmation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #482
Password reset is validated by the same ruleset that any
regular update is. It's going to fail everytime because instead of
sending the required fields for
updateruleset validation, it's only sendingpasswordandpassword_confirmation.This PR adds a method on
ConfideUserthat provides abooleanto bechecked at
savemethod and change the ruleset to'password_reset' whichrequires only
passwordandpassword_confirmationto pass on.Due to the
booleanvariable that needs to get passed onpasswordResetUserRepositoryandUserControllersuffered minor changes.This PR also allows all accordingly validation messages to be sent to final user
instead of only showing him/her a generic Confide Lang defined error
message.
Dunno if this will break any tests, take it as a proposal template if so.
🍻