Fix bypassing protection for bucket empty#1410
Open
daniel-skopek wants to merge 1 commit intoZrips:masterfrom
Open
Fix bypassing protection for bucket empty#1410daniel-skopek wants to merge 1 commit intoZrips:masterfrom
daniel-skopek wants to merge 1 commit intoZrips:masterfrom
Conversation
|
The video cannot be played, and why is there such a big difference in your PR? |
Author
|
Added text - steps to reproduce. Different change in my PR is because I'm using LF (UNIX/MacOS - \n) line separator (which is today's standard). Residence repo uses CLRF (Windows - \r\n) line separator. |
daniel-skopek
force-pushed
the
bucket-empty-fix
branch
from
4392302 to
c0d9e2b
Compare
|
This PR does not account for the protection of cauldrons and waterlogged blocks inside Residence claim borders. I have fixed and improved this in my PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bypass for placing water/lava into a residence: #1409