chore(deps): switch arkworks fork from twist-shout to jolt#1268
Open
chore(deps): switch arkworks fork from twist-shout to jolt#1268
Conversation
Point workspace and host template patches to the a16z arkworks `jolt` branch, then refresh Cargo.lock through a targeted build so only the arkworks git set updates. This keeps zeroos/reth pins unchanged while integrating the new arkworks branch. Co-authored-by: Cursor <cursoragent@cursor.com>
…ity fix Update the arkworks `jolt` git dependency set to commit `0be48f9` so Jolt CI picks up the carry/borrow intrinsic compatibility change required by older toolchains. Co-authored-by: Cursor <cursoragent@cursor.com>
Refresh only the arkworks git dependency set in Cargo.lock to pick up the current `a16z/arkworks-algebra` `jolt` branch head needed for Jolt CI compatibility. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
So i think the plan would be hopefully later get rid of any branch/fork right? I.e just use the standard cargo deps? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch Jolt's arkworks dependency source from
a16z/arkworks-algebrabranchdev/twist-shoutto branchjolt.This switch is done so Jolt consumes the new arkworks
joltbranch that is rebased onto current upstream master (i.e., on top of current master), instead of continuing to depend ondev/twist-shout, which was many commits behind master.Key Changes
[patch.crates-io]arkworks entries inCargo.tomltobranch = "jolt".ark-bn254,ark-grumpkin,ark-ec,ark-ff,ark-serialize,ark-secp256k1,jolt-optimizations) tobranch = "jolt".src/main.rsto emitbranch = "jolt".Cargo.lockto...branch=jolt#e1988d78....Testing
cargo buildpasses locally after switching tobranch = "jolt"cargo update)Review Guidance
Focus on the dependency redirection and lockfile scope:
branch = "jolt".Cargo.lockupdates are limited to arkworks-related graph changes.zeroos/rethgit pins.