perf(dory): cache affine G1 bases for streaming commitment#1393
Open
perf(dory): cache affine G1 bases for streaming commitment#1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_chunkandprocess_chunk_onehotconvert the same G1 generators from projective to affine form on every call — once per row of the streaming commitment. For a typical proof this happens hundreds of times, each incurring a batch field inversion that produces the same result.This PR caches the affine G1 bases in a module-level
RwLock<Vec<G1Affine>>, initialized once duringsetup_proverviaG1Projective::normalize_batch. Subsequent calls read from the cache with no conversion overhead. The cache is cleared inreset()for test isolation, andaffine_g1_bases_or_init()provides lazy initialization as a fallback.Also removes the
unsafe from_raw_partspointer aliasing that was previously used to access the G1 slice.