refactor(zkvm): move e2e tests out of prover#1401
Open
aproskill81 wants to merge 1 commit intoa16z:mainfrom
Open
refactor(zkvm): move e2e tests out of prover#1401aproskill81 wants to merge 1 commit intoa16z:mainfrom
aproskill81 wants to merge 1 commit intoa16z:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move guest-level zkVM end-to-end tests out of
jolt-core/src/zkvm/prover.rsinto a dedicatedjolt-core/src/zkvm/e2e_tests.rsmodule.This keeps
prover.rsfocused on prover logic and prover-coupled tests, while preserving the existing e2e coverage in a layout that is easier to extend for future Dory configuration sweeps.What changed
jolt-core/src/zkvm/e2e_tests.rszkvm/prover.rszkvm/mod.rsprover.rsTests moved
fib_e2e_dorysmall_trace_e2e_dorysha3_e2e_dorysha2_e2e_dorysha2_e2e_dory_with_unused_adviceadvice_e2e_dorymemory_ops_e2e_dorybtreemap_e2e_dorymuldiv_e2e_dorystdlib_e2e_doryfib_e2e_dory_address_majoradvice_e2e_dory_address_majorTests intentionally kept in
prover.rsThese remain in place because they are more tightly coupled to prover internals, tampering/security properties, or BlindFold-specific behavior:
max_advice_with_small_traceadvice_opening_point_derives_from_unified_pointblindfold_r1cs_satisfactiontruncated_tracemalicious_traceinitial_pc_is_constrained_to_entry_pointblindfold_protocol_e2eValidation
Ran targeted formatting and test coverage for the refactor.
Examples:
rustfmt --edition 2021 jolt-core/src/zkvm/prover.rs jolt-core/src/zkvm/mod.rs jolt-core/src/zkvm/e2e_tests.rscargo nextest run -p jolt-core ... --features hostcargo nextest run -p jolt-core ... --features host,zkCloses #1208