Skip to content

Conversation

@agilyol
Copy link
Contributor

@agilyol agilyol commented Oct 22, 2025

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@agilyol agilyol requested a review from a team as a code owner October 22, 2025 15:25
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @agilyol, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the create_text_message_object helper function by introducing new optional parameters for extensions and metadata. This change allows for richer and more detailed message construction, aligning with broader message object capabilities. Additionally, it refines the handling of the content parameter to ensure it always defaults to an empty string when not explicitly provided, improving the function's robustness.

Highlights

  • Function Parameter Expansion: The create_text_message_object function now accepts extensions (a list of Any) and metadata (a dictionary of Any) as optional input parameters. This allows for the creation of more comprehensive Message objects.
  • Robust Content Handling: The content parameter within the TextPart constructor now explicitly defaults to an empty string if the provided content is None or falsy, ensuring consistent message part creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the create_text_message_object helper function by allowing extensions and metadata to be passed, which is a great addition. My review includes a few suggestions to improve type safety and code clarity. I've also noted that the new functionality is not covered by tests, and it would be beneficial to add them. Lastly, please consider updating the pull request title to follow the Conventional Commits specification, for example by prefixing it with feat:.

@holtskinner holtskinner changed the title update create_text_message_object to accept other input parameters feat: update create_text_message_object() to accept other input parameters Oct 22, 2025
Copy link
Member

@holtskinner holtskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the Gemini-suggested changes and run the ruff check and formatter

bash scripts/format.sh

agilyol and others added 5 commits October 22, 2025 11:31
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@agilyol
Copy link
Contributor Author

agilyol commented Oct 22, 2025

Hi @holtskinner fixed comments and added test for it, will be glad if you could take a look. Thanks in advance

@agilyol agilyol requested a review from holtskinner October 22, 2025 16:42
response = await client.send_message(request=params)

assert isinstance(response, Message)
assert response.model_dump() == success_response.model_dump()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is much value in adding additional tests for the send_message method here, but it introduces unnecessary complexity. Could you directly test the create_text_message_object function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants