Fix deploy workflow

[a5chin]

User description

Type of Change

• Hotfix
• Bug Fix
• Dependency Update
• Feature
• Refactor
• CI/CD
• Documentation

Related Issues

Breaking Changes

• No breaking changes
• API signature changed
• Configuration changed
• Behavior changed
• Dependencies changed
• Features removed

Checklist

• Dependencies added/updated
• New environment variables
• Performance impact assessed
• Security implications reviewed
• Deployment notes

Additional Context

---

PR Type

Enhancement, CI/CD

---

Description

• Introduces GitHub Environments for Develop, Production, and github-pages.

• Applies branch protection rules for the develop branch.

• Refactors release workflow to target develop and main branches distinctly.

• Sets develop as the default repository branch.

---

Diagram Walkthrough

flowchart LR
  A["setting.yml workflow"]
  B[".github/environments.json"]
  C[".github/protection.json"]
  D["GitHub Environments (Develop, Production, github-pages)"]
  E["Branch Protection Rules (develop, main)"]
  F["release.yml workflow"]
  G["gh-deploy.yml workflow"]

  A -- "reads" --> B
  A -- "reads" --> C
  A -- "configures" --> D
  A -- "applies" --> E
  F -- "uses" --> D
  G -- "uses" --> D

Loading

File Walkthrough

	Relevant files
Configuration changes	2 files environments.json Defines GitHub environments for Develop, Production, and github-pages. +23/-0    protection.json Adds branch protection rules for the `develop` branch.      +15/-0
Deletion	1 files draft.yml Removes the draft release workflow.                                            +0/-27
Ci/cd	5 files gh-deploy.yml Assigns the `github-pages` environment to the deployment job. +2/-0      publish-app.yml Updates push trigger branch from `main` to `develop`.        +1/-1      publish-devcontainer.yml Updates push trigger branch from `main` to `develop`.        +1/-1      release.yml Refactors release workflow for develop and production environments. +25/-2    setting.yml Enhances repository settings, branch protection, and environment configuration. +67/-9

---

[a5chin]

/review

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Incomplete Job The 'production' job in the release workflow is currently incomplete. It only includes a checkout step and lacks the release drafting or publishing logic that the 'develop' job has. This might lead to inconsistent release behavior between develop and main branches. production: if: github.event.pull_request.merged == true && github.base_ref == 'main' runs-on: ubuntu-latest environment: Production steps: - name: Checkout uses: actions/checkout@v6 Branch Protection The 'develop' branch protection rules define an empty 'required_status_checks.contexts' array. This means that no specific status checks are required to pass before a pull request can be merged into 'develop', potentially allowing broken code to be merged. "required_status_checks": { "contexts": [], "strict": true Environment Configuration The 'reviewers' array is empty and 'wait_timer' is set to 0 for all defined environments. For 'Develop' and especially 'Production' environments, it is often beneficial to configure specific reviewers or a wait timer to ensure proper oversight before deployments. "reviewers": [], "wait_timer": 0

[a5chin]

/improve

[a5chin]

/improve