Avoid carriage return bug when configuring libuv on Windows#165
Avoid carriage return bug when configuring libuv on Windows#165tobil4sk wants to merge 2 commits intoaantron:masterfrom
Conversation
Carriage returns will appear when running the command on windows, which means that the configure script cannot function correctly because it relies on the host value to locate certain executables (such as `ar`).
I've changed it to the built-in dune variable |
|
@aantron Please could you consider merging this? It's currently the easiest fix to help improve windows support, to avoid having to manually add It's worth noting that this issue didn't affect github ci using setup-ocaml because that uses the You can also reproduce the failure with setup-ocaml by overriding - run: opam exec -- dune build -p luv
env:
BASH_ENV: |
Carriage returns will appear when running the command on windows, which means that the configure script cannot function correctly because it relies on the host value to locate certain executables (such as
ar).This is actually the cause of #162. Fixing this doesn't completely solve (local) windows builds, as dune doesn't currently run the correct bash executable, see: ocaml/dune#11438. This can be worked around by adding the output of
$(opam exec -- cygpath -w /bin)to PATH.Alternatively, this could all be replaced with
ocamlc -config-var hostwhich is cleaner, but that would increase the required ocaml version to 4.08. What would your preference be? @aantronCloses #162