--added the option to filter routes by config value #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my propose to add an ability to filter routes by specific key. For now by default all routes are added and then some of them are excluded by
laroute => falsekey. While in many cases it is fine there are situations like mine when I use some routes that are coming from some package and I have no chance to exclude them from routing in the current way. So I came with the idea of filter option in config which allows us to set the key to filter all routes by. So if we set it to 'jsroutes' we will only get the routes that have this key set to true, but we still can set laroute to false and exlude some of them.