feat: add new contract to support merkl reward claiming#112
Open
feat: add new contract to support merkl reward claiming#112
Conversation
aa-eyup
force-pushed
the
feat/merkl-rewards
branch
4 times, most recently
from
1c758c8 to
c4178fe
Compare
aa-eyup
force-pushed
the
feat/merkl-rewards
branch
2 times, most recently
from
f707b9d to
6069218
Compare
- inherits from ATokenVault - updates storage struct to store merkl distributor contract (consumes the first of 50 gap slots) - expose functions to set/get distributor (onlyOwner) - expose function to claim rewards from merkl distributor (onlyOwner) - add test that forks Ethereum mainnet to claim rewards
aa-eyup
force-pushed
the
feat/merkl-rewards
branch
from
6069218 to
34ae3cb
Compare
miguelmtzinf
reviewed
Dec 4, 2025
miguelmtzinf
reviewed
Dec 4, 2025
miguelmtzinf
reviewed
Dec 4, 2025
miguelmtzinf
reviewed
Dec 4, 2025
miguelmtzinf
reviewed
Dec 4, 2025
- make comments more concise - clarify in comment that native asset can not be rescued - move custom interface into a /dependencies dir - order read/write functions on ATokenVaultMerklRewardsClaim contract and interface
- an operator will be set on the reward distributor contract - an operator can claim rewards on behalf of a user (rewards are still sent to the user i.e. the ATokenVault)
aa-eyup
force-pushed
the
feat/merkl-rewards
branch
from
422ca9b to
896fd68
Compare
aa-eyup
force-pushed
the
feat/merkl-rewards
branch
from
a2065b4 to
7d5c2f0
Compare
aa-eyup
force-pushed
the
feat/merkl-rewards
branch
from
2783fa4 to
558c9ef
Compare
…ward reward tokens to
| * @param destination Address of the destination receiving the reward token | ||
| * @param amount Amount of the reward token transferred to the destination | ||
| */ | ||
| event MerklRewardsTokenForwarded(address indexed token, address indexed destination, uint256 indexed amount); |
Member
There was a problem hiding this comment.
We could do smt similar to RewardsClaimed, and emit the destination, tokens array and amounts array.
Author
There was a problem hiding this comment.
I have no strong preference, but I wanted to avoid emitting the event if the rewardTokensToForward array is empty. If you have a strong preference please lmk. Maybe we return early if rewardTokensToForward is empty then iterate through the tokens then emit an event at the event.
Imagine it would look like this:
event MerklRewardsTokenForwarded(address indexed destination, address[] tokens, uint256[] amounts);
We can also pass in an array of destinations to claimMerklRewards(...) if you think the flexibility would be valuable - then the single token/amount/destination event makes more sense.
…ing of aToken - The change is intended to protect against an attack which leverages a malicious distributor contract which enters into the ATokenVault via depositATokens(uint256 assets, address receiver) then forwards the aToken after the IMerklDistributor::claim call executes, effectively allowing an actor to obtain vault shares for free
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there is exists no way for an ATokenVault supplying to Aave to claim Merkl rewards. This change adds a contract that inherits from the upgradeable
ATokenVaultand adds functionality to claim Merkl rewards from a distributor address. If existing ATokenVault instances want to upgrade to support these functions then it can be done as this change consumes one of the gap slots reserved for upgrades to hold the Merkl distributor address.Changes