Use Enumerable#to_h to avoid extra allocation#6
Closed
the-spectator wants to merge 1 commit intoabachman:masterfrom
Closed
Use Enumerable#to_h to avoid extra allocation#6the-spectator wants to merge 1 commit intoabachman:masterfrom
the-spectator wants to merge 1 commit intoabachman:masterfrom
Conversation
|
Further addressed in PR #10 |
Owner
|
closing in favor of #10, which changes the same location |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can avoid extra allocation by directly calling
#to_honENCODING.split('').each_with_indexinstead of first converting it to an array and then converting it to a hash.This is not a Hot path for this library as constants are generated only on load. Please feel free to close the PR if this qualifies as a cosmetic change.