Conversation
SmithPeder
force-pushed
the
docker-build
branch
22 times, most recently
from
ac0d022 to
44655a1
Compare
SmithPeder
force-pushed
the
docker-build
branch
from
44655a1 to
66890af
Compare
odinuge
left a comment
odinuge
left a comment
There was a problem hiding this comment.
Can you split this into multiple logical PRs instead? In its current state it has 41 changed files, and is doing multiple independent things at the same time..
I would at least like to don't move the tex files in this PR, and make a separate one do that, to make it easy to see that this is not changing the content. It will also break git blame, so imo. we should not do unless we have a good reason to do it....
| cp public/*.pdf public/archive/$TIMESTAMP.pdf | ||
|
|
||
| # Clean up the Statutter directory, as it used to genereate fles | ||
| rm -f ./statutter/*.log \ |
There was a problem hiding this comment.
Why do we need to remove these files?
| @@ -0,0 +1,33 @@ | |||
| TIMESTAMP=`eval date +%d.%B.%Y` | |||
There was a problem hiding this comment.
Do we really need a shell script to generate them, instead of the Makefile?
If we have a shell-script, it should at least do proper error handling to make it possible to understand if something fails...
There was a problem hiding this comment.
We should at least enforce shellcheck
| event: | ||
| - pull_request | ||
|
|
||
| - name: push |
There was a problem hiding this comment.
It doesn't work yet, but it's supposed to do the same things as Travis does, where it builds then pushes the public code to another branch, which is served.
The whole process isn't planned yet.
|
|
||
| Den mounter de tre volumene `statutter, static og public` som blir brukt av bildet når den bygger statutter. | ||
|
|
||
| I tillegg kan du sende inn `ASSEMBLY_DATE` som en variabel, og den genererte pdf filen som blir arkivert får dette navnet. |
There was a problem hiding this comment.
What is this env-var doing?
There was a problem hiding this comment.
That was a thing back in the day, but now it's deprecated.
| -v `pwd`/static:/static/ \ | ||
| -v `pwd`/public:/public/ \ | ||
| -e ASSEMBLY_DATE=01.januar.1970 \ | ||
| abakus/statuttbuilder:latest |
There was a problem hiding this comment.
Isn't it better to use the Dockerfile instead, to make sure that the correct version is used?
There was a problem hiding this comment.
That might be a good idea
|
All valid questions :) I was supposed to set this as a draft, just wanted to get the |
|
An idea I had that might be better than committing the pdfs, is to attach them as release files on push to master (and create a new release). I don't know if it's much better or worse, but I think it's a bit cleaner and it might be a better way to keep a history. @SmithPeder This way the different versions (releases) are more directly associated with a commit as well. |
3 participants
No description provided.