Fix the negative image only converting 1/3 of the image#8
Open
Absolute-Arthur wants to merge 2 commits intoabhijitnathwani:masterfrom
Open
Fix the negative image only converting 1/3 of the image#8Absolute-Arthur wants to merge 2 commits intoabhijitnathwani:masterfrom
Absolute-Arthur wants to merge 2 commits intoabhijitnathwani:masterfrom
Conversation
Owner
|
Hi @Absolute-Arthur |
Author
|
It is really any BMP image I had, be it an image of a banana or an image of a landscape (converted using Paint). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only modifies the negative_image.c
Currently, the width and height values are taken straight from the header, and used directly, assuming that 1 byte = 1 pixel. This results in corrupted image results, which, when viewed with a viewer handling this corruption, reveals that only 1/3 of the original image is treated and put in the result image.
The reason is that each pixel has 3 bytes, corresponding to the 3 colors of RGB.
Simply multiplying these values by 3 fixes this, allowing the memory allocations to ask for 3 times the size and treating the whole image.