-
Notifications
You must be signed in to change notification settings - Fork 61
Release 2.10.0 #2050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.10.0 #2050
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis update increments the package version to 2.10.0, updates the changelog with new features and deprecations, and synchronizes the version constant in the React hooks source file. No functional code changes are introduced beyond these versioning and documentation updates. Changes
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm warn EBADENGINE Unsupported engine { 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/platform/react-hooks/src/AblyReactHooks.ts (1)
15-15: Prefer deriving the version frompackage.jsonto prevent driftHard-coding the version string here means every release requires a manual edit and risks divergence from
package.json. Consider importing the version at build time instead.Example (ES2022 / TS ≥5.0):
-import { /* existing imports */ } from 'ably'; +import * as Ably from 'ably'; +// eslint-disable-next-line @typescript-eslint/consistent-type-imports +import pkg from '../../../../package.json' assert { type: 'json' }; -export const version = '2.10.0'; +export const version: string = pkg.version;If your bundler can’t handle JSON asserts, alternative solutions include a small build-time plugin that replaces a
__SDK_VERSION__placeholder.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)package.json(1 hunks)src/platform/react-hooks/src/AblyReactHooks.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: test-node (16.x)
- GitHub Check: test-node (20.x)
- GitHub Check: test-browser (firefox)
- GitHub Check: test-browser (webkit)
- GitHub Check: test-node (18.x)
- GitHub Check: test-browser (chromium)
- GitHub Check: test-npm-package
🔇 Additional comments (2)
package.json (1)
4-4: Ensure no lingering2.9.0references in the codebaseThe version bump looks correct. To avoid surprises, please double-check that no other hard-coded
'2.9.0'strings remain (e.g. in headers injected by build tools, test snapshots, docs).#!/usr/bin/env bash # List any occurrences of the old version that might have been missed. rg --line-number --fixed-strings '2.9.0' || trueCHANGELOG.md (1)
5-9: Changelog entry looks goodThe new 2.10.0 section is clear and follows the established format. 👍
ttypic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will wait for #2049 before merging this PR
Summary by CodeRabbit