Open
Conversation
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Collaborator
Author
|
@ziadhany please review this pr, I have added the Rockylinux importer and tests for it. |
ziadhany
requested changes
Aug 10, 2024
Collaborator
ziadhany
left a comment
ziadhany
left a comment
There was a problem hiding this comment.
Thanks @ambuj-1211, please see few nits below for your consideration
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
- Modified the severity score collection. - Refined docstrings Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
ambuj-1211
force-pushed
the
add-rockylinux-advisories
branch
from
3666fb1 to
20fd784
Compare
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
ziadhany
requested changes
Oct 15, 2024
Collaborator
There was a problem hiding this comment.
@ambuj-1211 Thank you! Please use the new pipeline and resolve the severity and reference issues, run the importer and print the logs.
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Collaborator
Author
|
@ziadhany I have made the changes and created the rockylinux pipeline code, here are the logs for it. |
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Collaborator
Author
|
@ziadhany please check this one also I have already made the suggested changes, please tell me if there are any other changes needed. |
Collaborator
Author
|
@ziadhany please review this one I have done most of the things please tell me what changes should I make. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #753