Open
Conversation
Predis v1.1 uses implicit nullable, which causes a ton of warnings when working with modern PHP versions. Just updating the dependency causes the code to work better.
Author
|
(Sorry about the commit spam, had a poorly configured GPG key) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Predis v1.1 uses implicit nullable, which causes a ton of warnings when working with modern PHP versions. Just updating the dependency causes the code to work better.
I would recommend tagging this a new major version since it drops support for PHP8
Thank you so much for your time maintaining this library and I hope this helps!