Solve issue with Grav autoescape feature #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add Grav autoescape support (see Tip at Step 4: "If variable is safe to render and contains HTML, always use |raw filter to make the template to work with autoescape turned on.", visit: https://learn.getgrav.org/17/themes/theme-tutorial) - Removed old browser support (eg. <!--[if lte IE 8]><script src="{{ url('theme://assets/js/ie/html5shiv.js') }}"></script><![endif]-->)
- Remove old browser support
- Remove old browser support (delete whole ie8.css)
- Remove old browser support (file ie9.css)
Added Grav autoescape feature
+ Added Theme feature "site_subtitle": In Theme configuration, it's possible to set a "site_subtitle", which will be shown below the site title in sidebar.
+ Added Theme feature "site_subtitle": In Theme configuration, it's possible to set a "site_subtitle", which will be shown below the site title in sidebar.
+ Added Theme feature "site_subtitle": In Theme configuration, it's possible to set a "site_subtitle", which will be shown below the site title in sidebar.
~ Bugfix Theme feature "site_subtitle": Used wrong String comparison
+ Added Grav autoescape feature
+ Added Grav autoescap feature + Customized for private use
+ Added Grav feature translation (based on https://learn.getgrav.org/16/content/multi-language)
+ Added Translation feature for button "continue reading"
+ Added additional translation + Added Grav autoescape feature
+ Added translation for Button Next/Previous and Content Type Blog
+ Fixed locale date based on https://learn.getgrav.org/16/content/multi-language (solution without Twig-Extension Intl)
+ Fixed locale date based on https://learn.getgrav.org/16/content/multi-language (without Twig-Extension Intl)
+ Fixed locale date (added dot for short forms)
+ Add Plugin Comments: Integration of comments output
+ Added Plugin Aura Author
|
@absalomedia do you plan to merge it and provide it in the latest build? |
Owner
|
@01Kuzma once I've resolved the merge conflicts, yes I will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theme didn't work with a fresh installation of Grav (latest version 1.7). Issue was based on Grav's autoescape function, which escaped all open/close tags for CSS and JS includes. In addition, I also started to remove old browser support (<= IE10): Microsoft doesn't support this browser since 2016 (https://www.microsoft.com/en-us/microsoft-365/windows/end-of-ie-support).