Remove puppet 3 support and add Puppet 5 support #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rendhalver
force-pushed
the
feature/puppet4_only
branch
3 times, most recently
from
a6f703a to
471f988
Compare
rendhalver
force-pushed
the
feature/puppet4_only
branch
from
471f988 to
8e5550b
Compare
PuppetDB: 6.0.1 better support for Puppet 4+ min puppet version is now 4.7.0 PostgreSQL: 5.1.0
rendhalver
changed the title
uvNikita
reviewed
Jul 18, 2018
| $lc_collection_name = downcase($puppet::collection) | ||
| yumrepo { "puppetlabs-${lc_collection_name}": | ||
| descr => "Puppet Labs Collection ${::puppet::collection} EL ${::operatingsystemmajrelease} - ${::architecture}", | ||
| baseurl => "http://yum.puppetlabs.com/el/${::operatingsystemmajrelease}/${::puppet::collection}/${::architecture}", |
There was a problem hiding this comment.
As far as I know, Puppet 5 packages are available in a separate repository for rpm-based distros, e.g. http://yum.puppetlabs.com/puppet5/el/7/x86_64 (note that puppet5 goes before /el/ part), as it's mentioned in puppet 5 installing instructions. Not sure if it's directly connected with this PR though.
Member
Author
There was a problem hiding this comment.
Thanks.
I hadn't tested this on RedHatish distros or dug too far into the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.