Fix hiera array merge sorting commands#15
Open
jsfrerot wants to merge 1 commit intoabstractitptyltd:masterfrom
Open
Fix hiera array merge sorting commands#15jsfrerot wants to merge 1 commit intoabstractitptyltd:masterfrom
jsfrerot wants to merge 1 commit intoabstractitptyltd:masterfrom
Conversation
Hiera deep merge sorts the command array causing issues if the "ALL" keyword is at the end of the line when we have disallowed commands. commands"=>["/usr/bin/puppet", "/bin/puppet", "!SHELLS", "!SU", "ALL"] In this case SHELLS and SU will not be disallowed... Also making sure the disallowed commands are at the end. I'm not a ruby programmer, if you feel this code can be improve feel free to do so.
Member
|
Thanks for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiera deep merge sorts the command array causing issues if the "ALL" keyword is at the end of the line when we have disallowed commands.
commands"=>["/usr/bin/puppet", "/bin/puppet", "!SHELLS", "!SU", "ALL"]
In this case SHELLS and SU will not be disallowed...
Also making sure the disallowed commands are at the end.
I'm not a ruby programmer, if you feel this code can be improve feel free to do so.