Fix project name length validation #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #27 The solution was generated using github copilot workspace. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/accso/SecureCheckPlus/issues/27?shareId=XXXX-XXXX-XXXX-XXXX).
Collaborator
Author
|
The solution generated by copilot was pretty much entirely wrong, so I reworked it and now it should be properly working. |
marcus67
reviewed
Jan 28, 2025
|
|
||
| projectId = serializers.CharField(source="project_id", read_only=True) | ||
| projectName = serializers.CharField(source="project_name", allow_blank=True, validators=[MaxLengthValidator(255)]) | ||
| projectName = serializers.CharField(source="project_name", allow_blank=True, max_length=255) |
Member
There was a problem hiding this comment.
How does this length relate to the maximum length of 25 characters declared in backend/analyzer/models.py?
Collaborator
Author
There was a problem hiding this comment.
Good catch, I haven't seen the constraint in models.py. I think that the check in project_serializer.py is then redundant and can be removed without losing validation. Is that correct? Or should we lave it, but reduce it to 25?
Member
|
I’m not quite sure, if the constraint in the model backend automatically propagates to the frontend. My guess would be that it does not. In any case the current length in the data model is too small. There’s actually another issue for the increase of the lengths. Note that we have make sure to use the model update mechanism of Django for this so that existing instances will be correctly patched model-wise.
See #26
|
Collaborator
|
This should be merged after 26-extended-field-lengths to avoid issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
The solution was generated using github copilot workspace.
For more details, open the Copilot Workspace session.