Skip to content

[WIP] bug: E2E new-features-verify.spec.ts — all 9 tests fail due to wrong store API usage#204

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/fix-209436471-1157698754-e68d1ad6-0a53-4ee6-b5cf-fc3718bbeafd
Closed

[WIP] bug: E2E new-features-verify.spec.ts — all 9 tests fail due to wrong store API usage#204
Copilot wants to merge 1 commit intomainfrom
copilot/fix-209436471-1157698754-e68d1ad6-0a53-4ee6-b5cf-fc3718bbeafd

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 19, 2026

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original prompt

This section details on the original issue you should resolve

<issue_title>bug: E2E new-features-verify.spec.ts — all 9 tests fail due to wrong store API usage</issue_title>
<issue_description>## Summary

All 9 tests in tests/e2e/new-features-verify.spec.ts fail. These are test bugs (wrong API usage), not application bugs.

Failures

1. Punch in/out tests (3 tests)

  • Error: state.setPunchIn is not a function
  • Cause: setPunchIn, setPunchOut, togglePunch live on transportStore, but window.__store only exposes projectStore
  • Fix: Either expose transportStore on window.__transportStore, or import and use it differently in tests

2. Markers tests (3 tests)

  • Error: Cannot read properties of undefined (reading 'length') on s.getState().markers
  • Cause: Markers are at s.getState().project.markers, not s.getState().markers
  • Fix: Change all s.getState().markerss.getState().project.markers

3. Comping/Takes tests (2 tests)

  • Error: Cannot read properties of undefined (reading 'length') on s.getState().tracks
  • Cause: Tracks are at s.getState().project.tracks, not s.getState().tracks
  • Fix: Change all s.getState().trackss.getState().project.tracks
  • Also: addTrack() is called with { name, type } object but actual signature is addTrack(trackName: string, trackType?: string)

4. Edge case: keyboard shortcuts test (1 test)

  • Error: Same tracks path issue — s.getState().tracks.length → should be s.getState().project.tracks

5. createProject() call

  • Called as createProject('Test Project', 120) but actual signature is createProject({ name?: string, bpm?: number })

Affected file

tests/e2e/new-features-verify.spec.ts (added in PR #191)

Suggested fix

  • Fix store access paths (project.markers, project.tracks)
  • Expose transportStore as window.__transportStore for punch tests
  • Fix addTrack() and createProject() call signatures</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@ChuxiJ
Copy link
Copy Markdown

ChuxiJ commented Mar 19, 2026

Closing Copilot WIP — Claude Code/Codex taking over.

@ChuxiJ ChuxiJ closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: E2E new-features-verify.spec.ts — all 9 tests fail due to wrong store API usage

2 participants